linux-kernel - Re: 回复: 回复: [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f54d43ca-87cc-40bb-a56b-e49ee6a0a441@kernel.org>
Date: Thu, 28 Aug 2025 20:00:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Gary Yang <gary.yang@...tech.com>,
 "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>
Cc: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 cix-kernel-upstream <cix-kernel-upstream@...tech.com>
Subject: Re: 回复: 回复: [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1

On 28/08/2025 10:32, Gary Yang wrote:
> Hi Krzysztof,
> 
>>
>> On 28/08/2025 08:44, Gary Yang wrote:
>>>>
>>>>> +     if (ret) {
>>>>> +             dev_err(&pdev->dev, "fail to probe dt properties\n");
>>>>
>>>> You are printing same error twice. Drop this and just handle error
>>>> printing in sky1_pinctrl_probe_dt().
>>>> Especially that you now print errors on ENOMEM.
>>>>
>>>
>>> Sorry, this print message is only once, not twice, please give more
>>> information
>>
>> Trigger the error and check how many error messages you see. I see two.
>> You should know your code better than me...
>>
> 
> There are two pin-controller on sky1. They share the same driver. The probe is called twice. 
> 
> So we see the print message twice.


No, you don't really understand how this works. Test your code and its
error paths and you will see FOR ONE BIND more than one error message.
Plus my second comment which you completely ignored.

I am sorry, but this is basic C.

Best regards,
Krzysztof