linux-kernel - Re: [PATCH v2] docs: driver-api pinctrl cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbct3o-=-hy97OMg1O+E_Tw8cNzRTa_kh0WB2LxJrHwJw@mail.gmail.com>
Date: Thu, 28 Aug 2025 20:30:33 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: corbet@....net, linux-gpio@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: driver-api pinctrl cleanup

On Wed, Aug 27, 2025 at 9:45 AM Alex Tran <alex.t.tran@...il.com> wrote:

> changelog:
> v2

I think Jonathan will trim these two lines when applying...

> Replace FIXME comments in the pinctrl documentation example with
> proper cleanup code:
> - Add devm_pinctrl_put() calls in error paths
>   (pinctrl_lookup_state, pinctrl_select_state)
>   after successful devm_pinctrl_get()
> - Set foo->p to NULL when devm_pinctrl_get() fails
> - Add ret variable for cleaner error handling
> - provides proper example of pinctrl resource management on failure
>
> Signed-off-by: Alex Tran <alex.t.tran@...il.com>

... but it looks good otherwise!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij