linux-kernel - Re: [PATCH v2] docs: driver-api pinctrl cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ldn14x2c.fsf@trenco.lwn.net>
Date: Fri, 29 Aug 2025 15:50:19 -0600
From: Jonathan Corbet <corbet@....net>
To: Alex Tran <alex.t.tran@...il.com>, linus.walleij@...aro.org
Cc: linux-gpio@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, Alex Tran <alex.t.tran@...il.com>
Subject: Re: [PATCH v2] docs: driver-api pinctrl cleanup

Alex Tran <alex.t.tran@...il.com> writes:

> changelog:
> v2

It's best to keep this kind of stuff out of changelogs so the maintainer
doesn't have to edit it out when applying the patch.  I've taken care of
it this time.

> Replace FIXME comments in the pinctrl documentation example with
> proper cleanup code:
> - Add devm_pinctrl_put() calls in error paths 
>   (pinctrl_lookup_state, pinctrl_select_state) 
>   after successful devm_pinctrl_get()
> - Set foo->p to NULL when devm_pinctrl_get() fails
> - Add ret variable for cleaner error handling
> - provides proper example of pinctrl resource management on failure
>
> Signed-off-by: Alex Tran <alex.t.tran@...il.com>
> ---
>  Documentation/driver-api/pin-control.rst | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

Applied, thanks.

jon