linux-kernel - Re: [PATCH 2/2] selftests: Replace relative includes with non-relative for kselftest.h and kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250828081026.yx6vgphtsf4pmr3y@master>
Date: Thu, 28 Aug 2025 08:10:26 +0000
From: Wei Yang <richard.weiyang@...il.com>
To: Bala-Vignesh-Reddy <reddybalavignesh9979@...il.com>
Cc: akpm@...ux-foundation.org, shuah@...nel.org, mic@...ikod.net,
	gnoack@...gle.com, david@...hat.com, lorenzo.stoakes@...cle.com,
	Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org,
	surenb@...gle.com, mhocko@...e.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, ming.lei@...hat.com, skhan@...uxfoundation.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/2] selftests: Replace relative includes with
 non-relative for kselftest.h and kselftest_harness.h

On Wed, Aug 27, 2025 at 08:17:33PM +0530, Bala-Vignesh-Reddy wrote:
>Replaced relative path of kselftest.h and kselftest_harness.h
>to a non-relative path
>
>Signed-off-by: Bala-Vignesh-Reddy <reddybalavignesh9979@...il.com>
>
[...]
>diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c
>index d30625c18259..ccbb1958d467 100644
>--- a/tools/testing/selftests/mm/cow.c
>+++ b/tools/testing/selftests/mm/cow.c
>@@ -27,7 +27,7 @@
> #endif /* LOCAL_CONFIG_HAVE_LIBURING */
> 
> #include "../../../../mm/gup_test.h"
>-#include "../kselftest.h"
>+#include "kselftest.h"
> #include "vm_util.h"
> #include "thp_settings.h"
> 

Well there are too many changes and I failed to apply this one on current
mm-new. So I just manually change this with patch 1 applied.

This fails when I "cd tools/testing/selftests/mm/" and then make.

The Makefile in selftests/mm doesn't include ../Makefile so ../lib.mk doesn't
know the new CFLAGS when I do build in selftests/mm directory.

-- 
Wei Yang
Help you, Help me