linux-kernel - Re: [PATCH 2/2] selftests: Replace relative includes with non-relative for kselftest.h and kselftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250828094016.18063-1-reddybalavignesh9979@gmail.com>
Date: Thu, 28 Aug 2025 15:10:16 +0530
From: Bala-Vignesh-Reddy <reddybalavignesh9979@...il.com>
To: richard.weiyang@...il.com
Cc: Liam.Howlett@...cle.com,
	akpm@...ux-foundation.org,
	davem@...emloft.net,
	david@...hat.com,
	edumazet@...gle.com,
	gnoack@...gle.com,
	horms@...nel.org,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	linux-mm@...ck.org,
	linux-security-module@...r.kernel.org,
	lorenzo.stoakes@...cle.com,
	mhocko@...e.com,
	mic@...ikod.net,
	ming.lei@...hat.com,
	pabeni@...hat.com,
	reddybalavignesh9979@...il.com,
	rppt@...nel.org,
	shuah@...nel.org,
	skhan@...uxfoundation.org,
	surenb@...gle.com,
	vbabka@...e.cz
Subject: Re: [PATCH 2/2] selftests: Replace relative includes with non-relative for kselftest.h and kselftest_harness.h

Hi Wei,

Thanks for testing and for your feedback.

Yeah, if you try to build inside a subdirectory, the top level
export may not apply, so CFLAGS don't get updated, and even if
they did, the path could be pointing to wrong location.

As the docs recommend, building selftest using TARGETS,
either from kernel source or "tools/testing/selftests/"
works fine and doesn't fail.

If you really want to build from selftests/mm/ directory then
defining KSFT_INCLUDES with a fallback in the Makefile will
resolve it, but there is no need of it if we stick with "TARGETS=mm".

Thanks
Bala Vignesh