linux-kernel - Re: [PATCH] ALSA: lx_core: use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cy8fg7zq.wl-tiwai@suse.de>
Date: Thu, 28 Aug 2025 10:34:17 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: lx_core: use int type to store negative error codes

On Thu, 28 Aug 2025 10:13:10 +0200,
Qianfeng Rong wrote:
> 
> Change the 'ret' variable from u16 to int to store negative error codes or
> zero returned by lx_message_send_atomic().
> 
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but it's ugly as pants. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
> 
> No effect on runtime.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>

Applied now.  Thanks.


Takashi