linux-kernel - Re: [PATCH v5 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34290faa-0e0d-4935-a8c7-b2b1b052e37e@baylibre.com>
Date: Fri, 29 Aug 2025 09:33:20 -0500
From: David Lechner <dlechner@...libre.com>
To: Dixit Parmar <dixitparmar19@...il.com>,
 Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 1/2] iio: magnetometer: add support for Infineon
 TLV493D 3D Magentic sensor

On 8/29/25 7:05 AM, Dixit Parmar wrote:
>>>>> +INFINEON TLV493D Driver
>>>>> +M:   Dixit Parmar <dixitparmar19@...il.com>
>>>>> +L:   linux-iio@...r.kernel.org
>>>>> +S:   Maintained
>>>>> +W:   https://www.infineon.com/part/TLV493D-A1B6
>>>>> +F:   Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
>>>>
>>>> There is no such file here. Apply this *patch* and check by yourself.
>>> That file is being added as a separate patch(Patch 2/2) of this same
>>> patch series. It's already reviewed by you only(based on the name).
>>
>> No. Read my comment again:
> I am not sure If I understood what you exactly mean. Below is what I
> understood, please correct me if I am wrong.
>>
>> "Apply this *patch* and check by yourself."
>>
>> It does not matter if you add the file later. The file does not exist
>> now, here.
> 
> I have applied the patch on the latest mainline kernel codebase, it
> gets applied successfully.
> But yes, as you pointed out the
> Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml
> file does not exist by applying JUST THIS patch. That is because that
> file is introduced by a separate patch under the same
> patch series mentioned below.
> If this is not what you mean, I'd request to clarify to help me
> understand your concern.

Each patch should stand on it's own and not depend on later patches.
As you said below, the dt-bindings patch should come first in the
series. It is OK to also include a change to MAINTAINERS in that patch.
So you could include only this part:

+INFINEON TLV493D Driver
+M:	Dixit Parmar <dixitparmar19@...il.com>
+L:	linux-iio@...r.kernel.org
+S:	Maintained
+W:	https://www.infineon.com/part/TLV493D-A1B6
+F:	Documentation/devicetree/bindings/iio/magnetometer/infineon,tlv493d-a1b6.yaml

in the dt-bindings patch and then add:

+F:	drivers/iio/magnetometer/tlv493d.c

in the later driver patch.

This way, each F: entry is added in the same patch as the new file
it refers to.

> 
>>> https://lore.kernel.org/linux-iio/20250829-tlv493d-sensor-v6_16-rc5-v5-2-746e73bc6c11@gmail.com
>>>>
>>>> Your patchset is still incorrectly organized. See submitting patches in
>>>> DT dir.
>>> By "incorrectly organized" do you mean order of the patches in the
>>> patchset or anything else?
>>
>> I pointed to the docs, is anything unclear in there?
> I did referred the docs you
> pointed(Documentation/devicetree/bindings/submitting-patches.rst), as
> per that only one point which is
> being missed here that is #5 _The Documentation/ portion of the patch
> should come in the series before the code implementing the binding._
> That is applicable to dt-bindings patch of this patch series as the
> dt-bindings patch is a seperate patch.
> Apart from that, is there anything you think this patch is missing,
> kindly guide me.
> 
> Thank you for review,
> Dixit