linux-kernel - Re: [PATCH 2/2] mfd: 88pm886: Add GPADC cell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCF72OWEVZH0.3BSSAMUXM5I2J@matfyz.cz>
Date: Fri, 29 Aug 2025 22:30:09 +0200
From: "Karel Balej" <balejk@...fyz.cz>
To: "Andy Shevchenko" <andy.shevchenko@...il.com>,
        Duje Mihanović <duje@...emihanovic.xyz>
Cc: "Jonathan Cameron" <jic23@...nel.org>,
        "David Lechner"
 <dlechner@...libre.com>,
        Nuno Sá <nuno.sa@...log.com>,
        "Andy Shevchenko" <andy@...nel.org>, "Lee Jones" <lee@...nel.org>,
        "David
 Wronek" <david@...nlining.org>, <phone-devel@...r.kernel.org>,
        <~postmarketos/upstreaming@...ts.sr.ht>,
        <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 2/2] mfd: 88pm886: Add GPADC cell

Andy Shevchenko, 2025-08-29T18:47:19+03:00:
> On Fri, Aug 29, 2025 at 1:18 AM Duje Mihanović <duje@...emihanovic.xyz> wrote:
>>
>> Add a cell for the PMIC's onboard General Purpose ADC.
>
> ...
>
>>  static const struct mfd_cell pm886_devs[] = {
>
>>         MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources),
>>         MFD_CELL_NAME("88pm886-regulator"),
>>         MFD_CELL_NAME("88pm886-rtc"),
>> +       MFD_CELL_NAME("88pm886-gpadc"),
>
> List seems ordered, please prevent it.

Ah, I never explicitly realized to keep it ordered, seems like I was
just lucky to implement the components in the right order :-)

Anyway, yes, please keep it ordered. When you fix that, you may add

Acked-by: Karel Balej <balejk@...fyz.cz> # for the PMIC

Thanks,
K. B.