linux-kernel - Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DCF79FFP6NJS.J73DD94U1ZNK@matfyz.cz>
Date: Fri, 29 Aug 2025 22:38:57 +0200
From: "Karel Balej" <balejk@...fyz.cz>
To: Duje Mihanović <duje@...emihanovic.xyz>,
        "Jonathan
 Cameron" <jonathan.cameron@...wei.com>
Cc: "Jonathan Cameron" <jic23@...nel.org>,
        "David Lechner"
 <dlechner@...libre.com>,
        Nuno Sá <nuno.sa@...log.com>,
        "Andy Shevchenko" <andy@...nel.org>, "Lee Jones" <lee@...nel.org>,
        "David
 Wronek" <david@...nlining.org>, <phone-devel@...r.kernel.org>,
        <~postmarketos/upstreaming@...ts.sr.ht>,
        <linux-kernel@...r.kernel.org>, <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

Duje Mihanović, 2025-08-29T19:40:41+02:00:
> On Friday, 29 August 2025 18:27:30 Central European Summer Time Jonathan Cameron wrote:
>> On Fri, 29 Aug 2025 00:17:41 +0200
>> 
>> Duje Mihanović <duje@...emihanovic.xyz> wrote:
>> > +	iio->name = "88pm886-gpadc";
>> > +	iio->dev.parent = dev;
>> > +	iio->dev.of_node = parent->of_node;
>> 
>> Done in core code.
>> https://elixir.bootlin.com/linux/v6.16.3/source/drivers/iio/industrialio-core.
>> c#L2044 __iio_device_register() so unless you use it before that call
>> shouldn't need this.
>> 
>> I'm not sure what it is used for though.
>
> It was to explicitly bind the ADC (specifically, its IO channels) to
> the PMIC devicetree node. However, since the core does this already,
> will drop.

I believe the PMIC binding should probably be updated with the
#io-channel-cells property then, isn't that so?