linux-kernel - Re: [PATCHv4 1/3] dt-bindings: net: wireless: ath9k: add led bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9208c440-f9e3-4289-9c33-81bb35383d53@kernel.org>
Date: Fri, 29 Aug 2025 08:02:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rosen Penev <rosenp@...il.com>, "Rob Herring (Arm)" <robh@...nel.org>
Cc: Johannes Berg <johannes@...solutions.net>, devicetree@...r.kernel.org,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 linux-kernel@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
 linux-mips@...r.kernel.org, linux-wireless@...r.kernel.org,
 Toke Høiland-Jørgensen <toke@...e.dk>
Subject: Re: [PATCHv4 1/3] dt-bindings: net: wireless: ath9k: add led bindings

On 29/08/2025 03:47, Rosen Penev wrote:
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:92.15-25: Warning (reg_format): /example-2/ahb/wifi@...c0000/led:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:91.17-94.15: Warning (unit_address_vs_reg): /example-2/ahb/wifi@...c0000/led: node has a reg or ranges property, but no unit name
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:91.17-94.15: Warning (avoid_default_addr_size): /example-2/ahb/wifi@...c0000/led: Relying on default #address-cells value
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dts:91.17-94.15: Warning (avoid_default_addr_size): /example-2/ahb/wifi@...c0000/led: Relying on default #size-cells value
>> Documentation/devicetree/bindings/net/wireless/qca,ath9k.example.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250827005658.3464-2-rosenp@gmail.com
> FFS. These reviews were garbage. The next series will effectively be

What? My and Conor reviews were garbage?

It is your patches which never got tested, code was completely messed up
(see v2 mixing two different things).

I am not going to review your patches.

Best regards,
Krzysztof