[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250829-impetuous-hysterical-hornet-d7f6c6@kuoka>
Date: Fri, 29 Aug 2025 09:33:26 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Guoniu Zhou <guoniu.zhou@....com>
Cc: Rui Miguel Silva <rmfrfs@...il.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>, Martin Kepplinger <martink@...teo.de>,
Purism Kernel Team <kernel@...i.sm>, Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>,
Frank Li <Frank.Li@....com>, linux-media@...r.kernel.org, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/4] media: dt-bindings: nxp,imx8mq-mipi-csi2: Add
i.MX8ULP compatible string
On Thu, Aug 28, 2025 at 03:17:33PM +0800, Guoniu Zhou wrote:
> allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx8ulp-mipi-csi2
> + then:
> + properties:
> + reg:
> + minItems: 2
> + resets:
> + minItems: 2
> + maxItems: 2
> + clocks:
> + minItems: 4
> + clock-names:
> + minItems: 4
> + else:
> + properties:
> + clocks:
> + maxItems: 3
> + clock-names:
> + maxItems: 3
> +
> - if:
> properties:
> compatible:
> contains:
> enum:
> - fsl,imx8qxp-mipi-csi2
> + - fsl,imx8qm-mipi-csi2
> + not:
> + contains:
> + enum:
> + - fsl,imx8ulp-mipi-csi2
That's a nice trick, but I think you should just list exact cases.
It's also easier to read if if:then: blocks are symmetrical. Your
previous one consgtrained reg+resetes+clocks. This one constrains only
reg+resets.
> then:
> properties:
> reg:
> minItems: 2
> resets:
> maxItems: 1
> - else:
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - fsl,imx8mq-mipi-csi2
> + then:
> properties:
> reg:
> maxItems: 1
And this one constraints only "reg".
This stops being readable and maintainable.
Best regards,
Krzysztof
Powered by blists - more mailing lists