linux-kernel - Re: [PATCH] panic: use angle-bracket include for panic.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84349ainse.fsf@jogness.linutronix.de>
Date: Fri, 29 Aug 2025 09:40:41 +0206
From: John Ogness <john.ogness@...utronix.de>
To: Jinchao Wang <wangjinchao600@...il.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Qianqiang Liu <qianqiang.liu@....com>
Cc: linux-kernel@...r.kernel.org, Jinchao Wang <wangjinchao600@...il.com>,
    Petr Mladek <pmladek@...e.com>,
    Steven Rostedt <rostedt@...dmis.org>,
    Sergey Senozhatsky <senozhatsky@...omium.org>
Subject: Re: [PATCH] panic: use angle-bracket include for panic.h

Added CC printk folks...

On 2025-08-29, Jinchao Wang <wangjinchao600@...il.com> wrote:
> Replace quoted includes of panic.h with `#include <linux/panic.h>` for
> consistency across the kernel.
>
> Signed-off-by: Jinchao Wang <wangjinchao600@...il.com>

Reviewed-by: John Ogness <john.ogness@...utronix.de>

> ---
>  kernel/crash_core.c    | 2 +-
>  kernel/printk/nbcon.c  | 2 +-
>  kernel/printk/printk.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index bb38bbaf3a26..a5e8523dd6eb 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -4,7 +4,6 @@
>   * Copyright (C) 2002-2004 Eric Biederman  <ebiederm@...ssion.com>
>   */
>  
> -#include "linux/panic.h"
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/buildid.h>
> @@ -23,6 +22,7 @@
>  #include <linux/btf.h>
>  #include <linux/objtool.h>
>  #include <linux/delay.h>
> +#include <linux/panic.h>
>  
>  #include <asm/page.h>
>  #include <asm/sections.h>
> diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
> index 171480135830..558ef3177976 100644
> --- a/kernel/printk/nbcon.c
> +++ b/kernel/printk/nbcon.c
> @@ -2,7 +2,6 @@
>  // Copyright (C) 2022 Linutronix GmbH, John Ogness
>  // Copyright (C) 2022 Intel, Thomas Gleixner
>  
> -#include "linux/panic.h"
>  #include <linux/atomic.h>
>  #include <linux/bug.h>
>  #include <linux/console.h>
> @@ -13,6 +12,7 @@
>  #include <linux/irqflags.h>
>  #include <linux/kthread.h>
>  #include <linux/minmax.h>
> +#include <linux/panic.h>
>  #include <linux/percpu.h>
>  #include <linux/preempt.h>
>  #include <linux/slab.h>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 236f03937107..5aee9ffb16b9 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -17,7 +17,6 @@
>   *	01Mar01 Andrew Morton
>   */
>  
> -#include "linux/panic.h"
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/kernel.h>
> @@ -49,6 +48,7 @@
>  #include <linux/sched/clock.h>
>  #include <linux/sched/debug.h>
>  #include <linux/sched/task_stack.h>
> +#include <linux/panic.h>
>  
>  #include <linux/uaccess.h>
>  #include <asm/sections.h>
> -- 
> 2.43.0