linux-kernel - Re: [PATCH v3] dt-bindings: dma: img-mdc-dma: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250829-peculiar-pug-of-argument-1bfec0@kuoka>
Date: Fri, 29 Aug 2025 09:53:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nino Zhang <ninozhang001@...il.com>
Cc: devicetree@...r.kernel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, vkoul@...nel.org, rahulbedarkar89@...il.com, 
	linux-mips@...r.kernel.org, dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: dma: img-mdc-dma: convert to DT schema

On Mon, Aug 25, 2025 at 03:41:41PM +0800, Nino Zhang wrote:
> Convert the img-mdc-dma binding from txt to YAML schema.
> No functional changes except dropping the consumer node
> (spi@...00f00) from the example, which belongs to the
> consumer binding instead.
> 
> Signed-off-by: Nino Zhang <ninozhang001@...il.com>
> ---
> v2 -> v3:
> - Fix remaining issues based on Rob's and Krzysztof's comments.

That's vague. What exactly did you change?

Especially that this is not true. You never responded to comments, never
implemented them.

> - Link to v2: https://lore.kernel.org/all/20250824034509.445743-1-ninozhang001@gmail.com/
> 
> v1 -> v2:
> - Addressed review comments from Rob.
> - Link to v1: https://lore.kernel.org/all/20250821150255.236884-1-ninozhang001@gmail.com/
> 
>  .../bindings/dma/img,pistachio-mdc-dma.yaml   | 89 +++++++++++++++++++
>  .../devicetree/bindings/dma/img-mdc-dma.txt   | 57 ------------
>  2 files changed, 89 insertions(+), 57 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
>  delete mode 100644 Documentation/devicetree/bindings/dma/img-mdc-dma.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
> new file mode 100644
> index 000000000000..198e80b528c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/img,pistachio-mdc-dma.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/img,pistachio-mdc-dma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IMG Multi-threaded DMA Controller (MDC)
> +
> +maintainers:
> +  - Rahul Bedarkar <rahulbedarkar89@...il.com>
> +  - linux-mips@...r.kernel.org
> +
> +allOf:
> +  - $ref: /schemas/dma/dma-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: img,pistachio-mdc-dma
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    minItems: 1
> +    maxItems: 32

Nothing improved, so with vague commit msg it means you just ignored my
comment.

Best regards,
Krzysztof