linux-kernel - Re: [PATCH v3] dt-bindings: dma: img-mdc-dma: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250831053324.293327-1-ninozhang001@gmail.com>
Date: Sun, 31 Aug 2025 13:33:22 +0800
From: Nino Zhang <ninozhang001@...il.com>
To: krzk@...nel.org
Cc: conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dmaengine@...r.kernel.org,
	krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-mips@...r.kernel.org,
	ninozhang001@...il.com,
	rahulbedarkar89@...il.com,
	robh@...nel.org,
	vkoul@...nel.org
Subject: Re: [PATCH v3] dt-bindings: dma: img-mdc-dma: convert to DT schema

On Fri, 29 Aug 2025 09:53:43 +0200 Krzysztof Kozlowski wrote:
> > Convert the img-mdc-dma binding from txt to YAML schema.
> > No functional changes except dropping the consumer node
> > (spi@...00f00) from the example, which belongs to the
> > consumer binding instead.
> > 
> > Signed-off-by: Nino Zhang <ninozhang001@...il.com>
> > ---
> > v2 -> v3:
> > - Fix remaining issues based on Rob's and Krzysztof's comments.
> 
> That's vague. What exactly did you change?
> 
> Especially that this is not true. You never responded to comments, never
> implemented them.

Hi, Krzysztof,

You're right — my v3 changelog was too vague, and I should have replied
in this thread. Sorry about that.

For the record, my earlier, detailed replies were in the previous
threads:
Link: https://lore.kernel.org/all/20250824185543.475785-1-ninozhang001@gmail.com/

To summarise the concrete changes:
v2->v3:
- Ensured patches are not attached to unrelated/older threads.
- Dropped redundant '|' or '>' indicators in "description" fields.
- Dropped explicit "type" definition for "dma-channels" property.

v1->v2:
- Removed "Tested with 'make dt_binding_check'" from commit message.
- Renamed file to use the compatible string.
- Updated maintainers to Rahul Bedarkar and linux-mips@...r.kernel.org.
- Cleaned up redundant descriptions.
- Changed "minItems: 1" to "maxItems: 1" for "reg".
- Added "minItems: 1" and "maxItems: 32" for "interrupts".
- Added "maxItems: 1" for "clocks".
- Specified exact "clock-names" list with "items: - const: sys".
- Dropped redundant '|' indicators in descriptions.
- Added "minimum: 1" for "img,max-burst-multiplier".
- Removed unnecessary quotes in "required" section.
- Renamed example node "mdc: dma-controller@...43000" to "dma-controller@...43000".

If I still missed anything from your/Rob's comments, I'll fix it and
send a v4 shortly with:
- an explicit "Changes in v4" section in the commit message,
- inline replies in this thread to each point.

Thanks for pointing this out.

Best regards,
Nino