linux-kernel - Re: [PATCH v4 03/19] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef990ad24a95309250054cf40d06ceb2dabb27c1.camel@mediatek.com>
Date: Fri, 29 Aug 2025 11:10:39 +0000
From: Paul-pl Chen (陳柏霖) <Paul-pl.Chen@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>
CC: Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>, "robh@...nel.org"
	<robh@...nel.org>, Sunny Shen (沈姍姍)
	<Sunny.Shen@...iatek.com>, Sirius Wang (王皓昱)
	<Sirius.Wang@...iatek.com>, Nancy Lin (林欣螢)
	<Nancy.Lin@...iatek.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
	Xiandong Wang (王先冬)
	<Xiandong.Wang@...iatek.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"fshao@...omium.org" <fshao@...omium.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, Jason-JH Lin (林睿祥)
	<Jason-JH.Lin@...iatek.com>, Singo Chang (張興國)
	<Singo.Chang@...iatek.com>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "treapking@...omium.org" <treapking@...omium.org>
Subject: Re: [PATCH v4 03/19] dt-bindings: display: mediatek: add EXDMA yaml
 for MT8196

On Fri, 2025-08-29 at 08:48 +0200, Krzysztof Kozlowski wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Fri, Aug 29, 2025 at 08:35:23AM +0200, Krzysztof Kozlowski wrote:
> > On Thu, Aug 28, 2025 at 04:06:58PM +0800, Paul Chen wrote:
> > > From: Paul-pl Chen <paul-pl.chen@...iatek.com>
> > > 
> > > Add mediatek,exdma.yaml to support EXDMA for MT8196.
> > > The MediaTek display overlap extended DMA engine, namely
> > > OVL_EXDMA or EXDMA, primarily functions as a DMA engine
> > > for reading data from DRAM with various DRAM footprints
> > > and data formats.
> > > 
> > > Signed-off-by: Paul-pl Chen <paul-pl.chen@...iatek.com>
> > > ---
> > >  .../bindings/dma/mediatek,exdma.yaml          | 68
> > > +++++++++++++++++++
> > 
> > 
> > Your changelog says NOTHING changed here and this fails tests, so
> > does it
> > mean you received that warnings before but you keep sending same
> > broken
> > code?
> > 
> > Last two weeks of contributions from mediatek are absolutely
> > terrible.
> > Very poor code, basic in-house reviews not done, basic testing not
> > done.
> > 
> > I talked about this at OSSE 25 with some friends and got reasons
> > why
> > your setup is broken. Well, it's on you.
> > 
> > I was already raising this with Mediatek, but we are now back to
> > square
> > one.
> > 
> > NAK, because this patch WAS NEVER tested.
> 
> 
> And now I found you got EXACTLY the same error at v3, so you just
> never
> tested and ignored OUR test reports.
> 
> This is unfortunately an example how you waste reviewers' time.
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,
 
I apologize for resubmitting an insufficiently tested patch and wasting
reviewers’ time. The repeated failure and the inadequate changelog are
entirely my responsibility—no excuses. I’m withdrawing this revision
and will only resend after I’ve reproduced and fixed the failures,
validated with comprehensive tests, completed internal review, and
included a clear “Changes since vN.”
 
Thank you for the direct feedback—I will do better.
 
Best regards, Paul