linux-kernel - Re: [PATCH 1/2] dt-bindings: watchdog: Modify tesla fsd bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7bb127ed-8c1c-4379-9cee-f1178eb3fbc7@kernel.org>
Date: Sat, 30 Aug 2025 10:45:55 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varada Pavani <v.pavani@...sung.com>, s.nawrocki@...sung.com,
 cw00.choi@...sung.com, alim.akhtar@...sung.com, mturquette@...libre.com,
 sboyd@...nel.org, linux-samsung-soc@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: aswani.reddy@...sung.com, gost.dev@...sung.com
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Modify tesla fsd bindings

On 29/08/2025 15:56, Varada Pavani wrote:
> FSD SoC WDT is using Samsung legacy WDT driver with
> "samsung,exynos7-wdt" compatibility. Now change the compatibility due to
> few driver changes (PMU bit changes for each WDT instance and Clocks)
> for WDT found in FSD SoC.
> 
> Signed-off-by: Varada Pavani <v.pavani@...sung.com>
More comments:
1. Subject: completely vague, everything is modify, every binding is
"bindings". Write useful subjects.

2. ... and never tested :/
The amount of very poor contributions from Samsung recently skyrocketed.
Like 66% of contributions were not passing basic guidelines, basic
process, so should not have been sent.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof