linux-kernel - Re: [PATCH 2/2] arm64: dts: fsd: Fix Clock handle for WDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4770fec3-1b1c-4ade-aa3f-1ad097bbbb3f@kernel.org>
Date: Fri, 29 Aug 2025 16:14:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varada Pavani <v.pavani@...sung.com>, s.nawrocki@...sung.com,
 cw00.choi@...sung.com, alim.akhtar@...sung.com, mturquette@...libre.com,
 sboyd@...nel.org, linux-samsung-soc@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: aswani.reddy@...sung.com, gost.dev@...sung.com
Subject: Re: [PATCH 2/2] arm64: dts: fsd: Fix Clock handle for WDT

On 29/08/2025 15:56, Varada Pavani wrote:
> FSD SoC WDT has few changes when compared to exynos7 interms of Clocks,
> PMU register bits for each cluster. So use "tesla,fsd-wdt"

So what was added in 2022?

> compatibility for using correct driver data.
> FSD supports 2 Clocks for WDT (PCLK and CLK).
> - use fin_pll source Clock for all timer related calculations.
> - use bus Clock (IMEM_WDT0_IPCLKPORT_PCLK) to gate/ungate the register
> interface. Update both as per WDT UM.

No, you break all the users. Probably users don't care, but I do care
because I use that arguments for reviewing other patches, so I apply a
bit stricter rules for existing Samsung trees.

Otherwise provide rationale about impact and what was happening in 2022
with this code...


Best regards,
Krzysztof