linux-kernel - Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6191915.lOV4Wx5bFT@radijator>
Date: Sat, 30 Aug 2025 18:29:08 +0200
From: Duje Mihanović <duje@...emihanovic.xyz>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: David Lechner <dlechner@...libre.com>,
 Jonathan Cameron <jic23@...nel.org>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Karel Balej <balejk@...fyz.cz>,
 Lee Jones <lee@...nel.org>, David Wronek <david@...nlining.org>,
 phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

On Saturday, 30 August 2025 16:53:48 Central European Summer Time Andy Shevchenko wrote:
> On Sat, Aug 30, 2025 at 4:04 PM Duje Mihanović <duje@...emihanovic.xyz> wrote:
> > On Saturday, 30 August 2025 06:37:27 Central European Summer Time Andy Shevchenko wrote:
> > > On Fri, Aug 29, 2025 at 2:41 AM David Lechner <dlechner@...libre.com> wrote:
> > > > On 8/28/25 5:17 PM, Duje Mihanović wrote:
> > > > > +config 88PM886_GPADC
> > > > > +     tristate "Marvell 88PM886 GPADC driver"
> > > > > +     depends on MFD_88PM886_PMIC
> > > > > +     default y
> > > 
> > > Really? Why tristate then?
> > > I would expect default MFD_88PM886_PMIC instead,
> > > 
> > > > > +     help
> > > > > +       Say Y here to enable support for the GPADC (General Purpose
> > > > > ADC)
> > > > > +       found on the Marvell 88PM886 PMIC. The GPADC measures various
> > > > > +       internal voltages and temperatures, including (but not limited
> > > > > to)
> > > > > +       system, battery and USB.
> > > 
> > > Please, add a line about the module name if one chooses 'm'. Or see
> > > above — drop the "tristate" and explain why this driver may not be a
> > > module in the commit message.
> > 
> > 'default MFD_88PM886_PMIC' would make it y as that one is a bool. How
> > about 'default m if MFD_88PM886_PMIC' or, since this already depends on
> > _PMIC, 'default m'?
> 
> I didn't get it. Why? defaulting to MFD is okay, otherwise one needs
> to explain 'y' (and even explicit 'm' choice) for the _leaf_ driver.

I just wanted to keep the driver as modular as possible, including by
default. Regardless, this sounds OK to me.

Regards,
--
Duje