linux-kernel - Re: [PATCH 3/4] arm64: dts: rockchip: Add HINLINK H68K

Open Source and information security mailing list archives

Message-Id: <5285B176-5178-4F6F-8FB6-B898AC0EC939@tahomasoft.com>
Date: Sat, 30 Aug 2025 18:21:18 -0400
From: Erik Beck <xunil@...omasoft.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Chukun Pan <amadeus@....edu.cn>, Heiko Stuebner <heiko@...ech.de>,
 Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: Add HINLINK H68K


> On Aug 30, 2025, at 17:38, Andrew Lunn <andrew@...n.ch> wrote:
> 
> 
>> 
>>> +&gmac0 {
>>> +    assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
>>> +    assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
>>> +    assigned-clock-rates = <0>, <125000000>;
>>> +    clock_in_out = "output";
>>> +    phy-handle = <&rgmii_phy0>;
>>> +    phy-mode = "rgmii-id";
>> 
>> Please change phy-mode here to "rgmii". This change will yield an ethernet
>> speed throughput change of a factor of 100+.
> 
> Rockchip by default do bad things with RGMII delays.
> 
>  tx_delay:
>    description: Delay value for TXD timing.
>    $ref: /schemas/types.yaml#/definitions/uint32
>    minimum: 0
>    maximum: 0x7F
>    default: 0x30
> 
>  rx_delay:
>    description: Delay value for RXD timing.
>    $ref: /schemas/types.yaml#/definitions/uint32
>    minimum: 0
>    maximum: 0x7F
>    default: 0x10
> 
> Try setting both of these to 0. And then use 'rgmii-id'.
> 
>    Andrew

Thank you!
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives