linux-kernel - Re: [PATCH 05/12] mm/oom_kill: add `const` to pointer parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250830184940.5d83cdda762c849cf74d9dcc@linux-foundation.org>
Date: Sat, 30 Aug 2025 18:49:40 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Max Kellermann <max.kellermann@...os.com>
Cc: "Vishal Moola (Oracle)" <vishal.moola@...il.com>, david@...hat.com,
 axelrasmussen@...gle.com, yuanchu@...gle.com, willy@...radead.org,
 hughd@...gle.com, mhocko@...e.com, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
 vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com
Subject: Re: [PATCH 05/12] mm/oom_kill: add `const` to pointer parameter

On Sat, 30 Aug 2025 08:26:07 +0200 Max Kellermann <max.kellermann@...os.com> wrote:

> On Sat, Aug 30, 2025 at 1:03 AM Vishal Moola (Oracle)
> <vishal.moola@...il.com> wrote:
> > > -extern bool process_shares_mm(struct task_struct *p, struct mm_struct *mm);
> > > +extern bool process_shares_mm(struct task_struct *p, const struct mm_struct *mm);
> >
> > Nowadays we're dropping the extern keyword.
> 
> I can do that - is it acceptable to do that in the same patch?

The culture is "ooh ooh ooh, you can't do two things in the same
patch".  My culture is well, gee, it's simple and obvious and makes the
kernel better, so I think we can handle it.