linux-kernel - Re: [PATCH 08/12] arch, mm/util: add const to arch_pick_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKPOu+_VUMz5LxXEOVC9qQCQxjpHtm0dorJRxr34U1ff4jP7xQ@mail.gmail.com>
Date: Sun, 31 Aug 2025 11:07:30 +0200
From: Max Kellermann <max.kellermann@...os.com>
To: "Vishal Moola (Oracle)" <vishal.moola@...il.com>
Cc: akpm@...ux-foundation.org, david@...hat.com, axelrasmussen@...gle.com, 
	yuanchu@...gle.com, willy@...radead.org, hughd@...gle.com, mhocko@...e.com, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, lorenzo.stoakes@...cle.com, 
	Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com
Subject: Re: [PATCH 08/12] arch, mm/util: add const to arch_pick_mmap_layout() parameter

On Sat, Aug 30, 2025 at 1:36 AM Vishal Moola (Oracle)
<vishal.moola@...il.com> wrote:
> > -static inline int mmap_is_legacy(struct rlimit *rlim_stack)
> > +static inline int mmap_is_legacy(const struct rlimit *rlim_stack)
>
> Thanks for splitting the patch into all these smaller snippets, it makes
> review a lot easier. But this function should be part of the 6th patch
> since we'd want function signatures to change together :).

Will do.

There are 3 copies of this function which are slightly different:
- arch/s390/mm/mmap.c (checks rlim_stack)
- arch/x86/mm/mmap.c (does not check rlim_stack)
- mm/util.c (checks rlim_stack if CONFIG_STACK_GROWSUP)

I wonder if it would be best to merge all 3 into one? The one in
mm/util.c seems to be generic enough. Export it and have its prototype
in linux/mm.h?