[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <abd7a0e3-abe2-4125-8ddd-9dfad24a704b@kernel.org>
Date: Sun, 31 Aug 2025 11:06:38 +0200
From: Hans Verkuil <hverkuil+cisco@...nel.org>
To: Sunny Patel <nueralspacetech@...il.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: Hans Verkuil <hverkuil@...nel.org>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Ricardo Ribalda <ribalda@...omium.org>, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: v4l2-ctrls: Enable support for u64 value
On 31/08/2025 10:06, Sunny Patel wrote:
> Added Support for unsigned 64 bit value
>
> Signed-off-by: Sunny Patel <nueralspacetech@...il.com>
> ---
> include/media/v4l2-ctrls.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index c32c46286441..7b2bc459f378 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -250,6 +250,7 @@ typedef void (*v4l2_ctrl_notify_fnc)(struct v4l2_ctrl *ctrl, void *priv);
> * @cur.val: The control's current value, if the @type is represented via
> * a u32 integer (see &enum v4l2_ctrl_type).
> * @val: The control's new s32 value.
> + * @val64: The control's new u64 value.
> * @p_def: The control's default value represented via a union which
> * provides a standard way of accessing control types
> * through a pointer (for compound controls only).
> @@ -313,6 +314,7 @@ struct v4l2_ctrl {
> void *p_array;
> u32 p_array_alloc_elems;
> s32 val;
> + u64 val64;
> struct {
> s32 val;
> } cur;
????
This patch makes no sense whatsoever. Rejecting.
Regards,
Hans
Powered by blists - more mailing lists