linux-kernel - Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5048048.31r3eYUQgx@radijator>
Date: Sun, 31 Aug 2025 22:19:38 +0200
From: Duje Mihanović <duje@...emihanovic.xyz>
To: Jonathan Cameron <jic23@...nel.org>,
 David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Lee Jones <lee@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Karel Balej <balejk@...fyz.cz>
Cc: David Wronek <david@...nlining.org>, phone-devel@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

On Sunday, 31 August 2025 21:24:54 Central European Summer Time Karel Balej wrote:
> Duje Mihanović, 2025-08-31T12:33:05+02:00:
> > +	if (IS_ERR(page))
> > +		return dev_err_probe(dev, PTR_ERR(page), "Failed to initialize GPADC
> > page\n"); +
> > +	gpadc->map = devm_regmap_init_i2c(page, &pm886_gpadc_regmap_config);
> > +	if (IS_ERR(gpadc->map))
> > +		return dev_err_probe(dev, PTR_ERR(gpadc->map),
> > +				     "Failed to initialize GPADC regmap\n");
> > +
> > +	iio->name = "88pm886-gpadc";
> > +	iio->dev.of_node = dev->parent->of_node;
> 
> Didn't you mean to drop this since Jonathan pointed out that it's done
> by the core?

Actually I have found that device tree consumers fail to get their IO
channels without this line, so I left it.

Regards,
--
Duje