linux-kernel - Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLWU3AwC37jpV9W_@smile.fi.intel.com>
Date: Mon, 1 Sep 2025 15:43:08 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Duje Mihanović <duje@...emihanovic.xyz>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Lee Jones <lee@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Karel Balej <balejk@...fyz.cz>,
	David Wronek <david@...nlining.org>, phone-devel@...r.kernel.org,
	~postmarketos/upstreaming@...ts.sr.ht, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] iio: adc: Add driver for Marvell 88PM886 PMIC ADC

On Sun, Aug 31, 2025 at 10:19:38PM +0200, Duje Mihanović wrote:
> On Sunday, 31 August 2025 21:24:54 Central European Summer Time Karel Balej wrote:
> > Duje Mihanović, 2025-08-31T12:33:05+02:00:

...

> > > +	iio->dev.of_node = dev->parent->of_node;
> > 
> > Didn't you mean to drop this since Jonathan pointed out that it's done
> > by the core?
> 
> Actually I have found that device tree consumers fail to get their IO
> channels without this line, so I left it.

because the passed device is not parent?

In any case this line is problematic. Use device_set_node() instead with the
proper dev_fwnode() parameter.

-- 
With Best Regards,
Andy Shevchenko