[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20250901132617.18985-1-duoming@zju.edu.cn>
Date: Mon, 1 Sep 2025 21:26:17 +0800
From: Duoming Zhou <duoming@....edu.cn>
To: linux-media@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
mchehab@...nel.org,
tharvey@...eworks.com,
Duoming Zhou <duoming@....edu.cn>
Subject: [PATCH] media: TDA1997x: Remove redundant cancel_delayed_work in probe
The delayed_work delayed_work_enable_hpd is initialized with
INIT_DELAYED_WORK(), but it is never scheduled in tda1997x_probe().
Calling cancel_delayed_work() on a work that has never been
scheduled is redundant and unnecessary, as there is no pending
work to cancel.
Remove the redundant cancel_delayed_work() from error handling
path in tda1997x_probe() to avoid potential confusion.
Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver")
Signed-off-by: Duoming Zhou <duoming@....edu.cn>
---
drivers/media/i2c/tda1997x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
index 1087d2bddaf2..3532766cd795 100644
--- a/drivers/media/i2c/tda1997x.c
+++ b/drivers/media/i2c/tda1997x.c
@@ -2797,7 +2797,6 @@ static int tda1997x_probe(struct i2c_client *client)
err_free_handler:
v4l2_ctrl_handler_free(&state->hdl);
err_free_mutex:
- cancel_delayed_work(&state->delayed_work_enable_hpd);
mutex_destroy(&state->page_lock);
mutex_destroy(&state->lock);
tda1997x_set_power(state, 0);
--
2.34.1
Powered by blists - more mailing lists