linux-kernel - Re: [PATCH v8 3/5] ras: Export log_non_standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250901151658.GBaLW46ibJuf4kGgnl@fat_crate.local>
Date: Mon, 1 Sep 2025 17:16:58 +0200
From: Borislav Petkov <bp@...en8.de>
To: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org, git@....com, ptsm@...ux.microsoft.com,
	srivatsa@...il.mit.edu, shubhrajyoti.datta@...il.com,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Tony Luck <tony.luck@...el.com>, James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, Nipun Gupta <nipun.gupta@....com>,
	Nikhil Agarwal <nikhil.agarwal@....com>
Subject: Re: [PATCH v8 3/5] ras: Export log_non_standard_event for External
 Usage

On Tue, Aug 26, 2025 at 10:59:12AM +0530, Shubhrajyoti Datta wrote:
> The function log_non_standard_event is responsible for logging
> platform-specific or vendor-defined RAS (Reliability, Availability,
> and Serviceability) events. Currently, this function is only available
> within the RAS subsystem, preventing external modules from
> leveraging its capabilities.
> 
> log_non_standard_event is exported so that external drivers like VersalNet

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."


> EDAC can log non-standard RAS events.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@....com>
> ---
> 
> (no changes since v6)
> 
> Changes in v6:
> - Update the commit message.
> 
> Changes in v2:
> - New patch addition
> 
>  drivers/ras/ras.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ras/ras.c b/drivers/ras/ras.c
> index a6e4792a1b2e..ac0e132ccc3e 100644
> --- a/drivers/ras/ras.c
> +++ b/drivers/ras/ras.c
> @@ -51,6 +51,7 @@ void log_non_standard_event(const guid_t *sec_type, const guid_t *fru_id,
>  {
>  	trace_non_standard_event(sec_type, fru_id, fru_text, sev, err, len);
>  }
> +EXPORT_SYMBOL_GPL(log_non_standard_event);

In a pre-patch, pls delete this silly wrapper log_non_standard_event() and use
the tracepoint trace_non_standard_event() at the callsites instead.

Then you can use the same in your driver.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette