linux-kernel - Re: [PATCH v5 11/12] mm: constify assert/test functions in mm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKPOu+8xJJ91pOymWxJ0W3wum_mHPkn_nR7BegzmrjFwEMLrGg@mail.gmail.com>
Date: Mon, 1 Sep 2025 17:17:20 +0200
From: Max Kellermann <max.kellermann@...os.com>
To: David Hildenbrand <david@...hat.com>
Cc: akpm@...ux-foundation.org, axelrasmussen@...gle.com, yuanchu@...gle.com, 
	willy@...radead.org, hughd@...gle.com, mhocko@...e.com, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, lorenzo.stoakes@...cle.com, 
	Liam.Howlett@...cle.com, vbabka@...e.cz, rppt@...nel.org, surenb@...gle.com, 
	vishal.moola@...il.com, linux@...linux.org.uk, 
	James.Bottomley@...senpartnership.com, deller@....de, agordeev@...ux.ibm.com, 
	gerald.schaefer@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, 
	borntraeger@...ux.ibm.com, svens@...ux.ibm.com, davem@...emloft.net, 
	andreas@...sler.com, dave.hansen@...ux.intel.com, luto@...nel.org, 
	peterz@...radead.org, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
	x86@...nel.org, hpa@...or.com, chris@...kel.net, jcmvbkbc@...il.com, 
	viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz, weixugc@...gle.com, 
	baolin.wang@...ux.alibaba.com, rientjes@...gle.com, shakeel.butt@...ux.dev, 
	thuth@...hat.com, broonie@...nel.org, osalvador@...e.de, jfalempe@...hat.com, 
	mpe@...erman.id.au, nysal@...ux.ibm.com, linux-arm-kernel@...ts.infradead.org, 
	linux-parisc@...r.kernel.org, linux-s390@...r.kernel.org, 
	sparclinux@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v5 11/12] mm: constify assert/test functions in mm.h

On Mon, Sep 1, 2025 at 4:07 PM David Hildenbrand <david@...hat.com> wrote:
> > -static inline void assert_fault_locked(struct vm_fault *vmf)
> > +static inline void assert_fault_locked(const struct vm_fault *vmf)
> >   {
>
> This confused me a bit: in the upper variant it's "*const" and here it's
> "const *".

That was indeed a mistake. Both should be "const*const".

> There are multiple such cases here, which might imply that it is not
> "relatively trivial to const-ify them". :)

I double-checked this patch and couldn't find any other such mistake.
Or do you mean the function vs prototype thing on parameter values?