linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <q4t2cmg5xtzbga2u3nnxayvb3mom5zaffhyidki2h7pmctk6f4@syj4byco3pwi>
Date: Mon, 1 Sep 2025 11:01:31 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Barnabás Czémán <barnabas.czeman@...nlining.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alejandro Tafalla <atafalla@...on.com>, Luca Weiss <luca@...aweiss.eu>, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios

On Sat, Aug 30, 2025 at 11:59:30PM +0200, Barnabás Czémán wrote:
> Correct cd-gpios in xiaomi-daisy according to downstream sources
> it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.

Is the problem you're solving that the DT doesn't match downstream, or
that card detect doesn't work? Does it work after this patch, or is it
just aligned with downstream?

Regards,
Bjorn

> 
> Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for Xiaomi Mi A2 Lite")
> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
> index 336b916729e4721b5ba8f4f7e368d0d838aa54ab..ddd7af616794290aa1f06228a95cfa1d42b006e6 100644
> --- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
> @@ -296,7 +296,7 @@ &sdhc_2 {
>  	vmmc-supply = <&pm8953_l11>;
>  	vqmmc-supply = <&pm8953_l12>;
>  
> -	cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
> +	cd-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
>  
>  	pinctrl-names = "default", "sleep";
>  	pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
> 
> ---
> base-commit: 3cace99d63192a7250461b058279a42d91075d0c
> change-id: 20250830-daisy-sd-fix-011c23468e2a
> 
> Best regards,
> -- 
> Barnabás Czémán <barnabas.czeman@...nlining.org>
>