linux-kernel - Re: [PATCH v2] net/smc: Replace use of strncpy on NUL-terminated string with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250901160353.GL15473@horms.kernel.org>
Date: Mon, 1 Sep 2025 17:03:53 +0100
From: Simon Horman <horms@...nel.org>
To: James Flowers <bold.zone2373@...tmail.com>
Cc: alibuda@...ux.alibaba.com, dust.li@...ux.alibaba.com,
	sidraya@...ux.ibm.com, wenjia@...ux.ibm.com, mjambigi@...ux.ibm.com,
	tonylu@...ux.alibaba.com, guwen@...ux.alibaba.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, skhan@...uxfoundation.org,
	linux-rdma@...r.kernel.org, linux-s390@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v2] net/smc: Replace use of strncpy on NUL-terminated
 string with strscpy

On Sun, Aug 31, 2025 at 08:04:59PM -0700, James Flowers wrote:
> strncpy is deprecated for use on NUL-terminated strings, as indicated in
> Documentation/process/deprecated.rst. strncpy NUL-pads the destination
> buffer and doesn't guarantee the destination buffer will be NUL
> terminated.
> 
> Signed-off-by: James Flowers <bold.zone2373@...tmail.com>
> ---
> V1 -> V2: Replaced with two argument version of strscpy
> Note: this has only been compile tested.

Reviewed-by: Simon Horman <horms@...nel.org>