linux-kernel - Re: [PATCH] crypto: qat: Use library to prepare HMAC keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLXEFW/YF4LyukGp@gcabiddu-mobl.ger.corp.intel.com>
Date: Mon, 1 Sep 2025 17:04:37 +0100
From: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To: Eric Biggers <ebiggers@...nel.org>
CC: <linux-crypto@...r.kernel.org>, <qat-linux@...el.com>,
	<linux-kernel@...r.kernel.org>, Ard Biesheuvel <ardb@...nel.org>, "Jason A .
 Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH] crypto: qat: Use library to prepare HMAC keys

On Sun, Aug 31, 2025 at 01:54:57PM -0700, Eric Biggers wrote:
> Reimplementing the sha1, sha256, and sha512 crypto_shash algorithms on
> top of the library APIs caused the recently-added function
> crypto_shash_export_core() to no longer be supported.  Meanwhile, the
> QAT driver was updated to use crypto_shash_export_core().  But it's not
> actually necessary.  Instead, just do the HMAC key preparation using the
> library functions instead of crypto_shash.  This fixes the QAT driver
> and greatly simplifies the code.  Additional benefits include stronger
> typing, and improved performance due to reduced overhead.
> 
> Reported-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
> Closes: https://lore.kernel.org/r/aLSnCc9Ws5L9y+8X@gcabiddu-mobl.ger.corp.intel.com
> Fixes: ccafe2821cfa ("crypto: qat - Use crypto_shash_export_core")
> Fixes: 8bc79ab67d78 ("crypto: sha1 - Wrap library and add HMAC support")
> Fixes: e0cd37169103 ("crypto: sha256 - Wrap library and add HMAC support")
> Fixes: 469acaa12502 ("crypto: sha512 - Replace sha512_generic with wrapper around SHA-512 library")
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
Thanks.

One NIT on the headline, for consistency with the other patches:
"crypto: qat -".

Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

Regards,

-- 
Giovanni