linux-kernel - Re: [PATCH net-next 1/2] dt-bindings: net: Convert apm,xgene-enet to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175675161498.5921.10650849049249219942.robh@kernel.org>
Date: Mon, 01 Sep 2025 13:34:23 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 Iyappan Subramanian <iyappan@...amperecomputing.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Quan Nguyen <quan@...amperecomputing.com>, 
 Andrew Lunn <andrew+netdev@...n.ch>, Jakub Kicinski <kuba@...nel.org>, 
 Keyur Chudgar <keyur@...amperecomputing.com>, 
 "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, 
 Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: Convert apm,xgene-enet
 to DT schema

On Fri, 29 Aug 2025 15:28:14 -0500, Rob Herring (Arm) wrote:
> Convert the APM XGene Ethernet binding to DT schema format.
> 
> Add the missing apm,xgene2-sgenet and apm,xgene2-xgenet compatibles.
> Drop "reg-names" as required. Add support for up to 16 interrupts.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  .../bindings/net/apm,xgene-enet.yaml          | 114 ++++++++++++++++++
>  .../bindings/net/apm-xgene-enet.txt           |  91 --------------
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 115 insertions(+), 92 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/apm,xgene-enet.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/apm,xgene-enet.example.dtb: ethernet-phy-id001c.c915@3 (ethernet-phy-id001c.c915): $nodename:0: 'ethernet-phy-id001c.c915@3' does not match '^ethernet-phy(@[a-f0-9]+)?$'
	from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/apm,xgene-enet.example.dtb: ethernet-phy-id001c.c915@3 (ethernet-phy-id001c.c915): Unevaluated properties are not allowed ('reg' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250829202817.1271907-1-robh@kernel.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.