[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <175675758490.265131.17956569668520199935.robh@kernel.org>
Date: Mon, 1 Sep 2025 15:13:05 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: linux-arm-kernel@...ts.infradead.org,
Krzysztof Kozlowski <krzk@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
linux-samsung-soc@...r.kernel.org,
Guenter Roeck <linux@...ck-us.net>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-watchdog@...r.kernel.org,
Alim Akhtar <alim.akhtar@...sung.com>,
Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH 4/4] dt-bindings: watchdog: samsung-wdt: Split if:then:
and constrain more
On Sat, 30 Aug 2025 12:19:00 +0200, Krzysztof Kozlowski wrote:
> Binding defined two if:then: blocks covering different conditions but
> not fully constraining the properties per each variant:
> 1. "if:" to require samsung,syscon-phandle,
> 2. "if:" with "else:" to narrow number of clocks and require or disallow
> samsung,cluster-index.
>
> This still did not cover following cases:
> 1. Disallow samsung,syscon-phandle when not applicable,
> 2. Narrow samsung,cluster-index to [0, 1], for SoCs with only two
> clusters.
>
> Solving this in current format would lead to spaghetti code, so re-write
> entire "if:then:" approach into mutually exclusive cases so each SoC
> appears only in one "if:" block. This allows to forbid
> samsung,syscon-phandle for S3C6410, and narrow samsung,cluster-index
> to [0, 1].
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../devicetree/bindings/watchdog/samsung-wdt.yaml | 70 ++++++++++++++++------
> 1 file changed, 52 insertions(+), 18 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@...nel.org>
Powered by blists - more mailing lists