linux-kernel - Re: [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250901-rousing-orange-crab-c05fdf@kuoka>
Date: Mon, 1 Sep 2025 06:55:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Inbaraj E <inbaraj.e@...sung.com>
Cc: rmfrfs@...il.com, laurent.pinchart@...asonboard.com, martink@...teo.de, 
	kernel@...i.sm, mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de, 
	kernel@...gutronix.de, festevam@...il.com, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, pankaj.dubey@...sung.com, 
	ravi.patel@...sung.com, shradha.t@...sung.com
Subject: Re: [PATCH v3 2/7] dt-bindings: media: fsd: Add CSIS video capture
 interface

On Thu, Aug 28, 2025 at 02:29:06PM +0530, Inbaraj E wrote:
> The Tesla FSD CSIS video capture interface is used to capture frames.
> 
> Signed-off-by: Inbaraj E <inbaraj.e@...sung.com>
> ---
>  .../bindings/media/tesla,fsd-csis-media.yaml  | 76 +++++++++++++++++++
>  1 file changed, 76 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml b/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml
> new file mode 100644
> index 000000000000..f045094ae539
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/tesla,fsd-csis-media.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Tesla FSD SoC MIPI CSI-2 video capture interface(Bridge device).

Drop final full stop. Also missing space before (


> +
> +maintainers:
> +  - Inbaraj E <inbaraj.e@...sung.com>
> +
> +description:
> +  The Tesla FSD CSIS has an internal video capture interface to capture
> +  frames originating from the sensor. The power supply for the IP is
> +  managed by custom firmware and is expected to remain enabled
> +  permanently, so power supply control is not added in linux.
> +
> +properties:
> +  compatible:
> +    const: tesla,fsd-csis-media
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 3
> +
> +  clock-names:
> +    items:
> +      - const: aclk
> +      - const: pclk
> +      - const: pll
> +
> +  iommus:
> +    maxItems: 1
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - iommus
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/fsd-clk.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    csis0: csis@...41000 {

Incorrect unit address.

> +        compatible = "tesla,fsd-csis-media";
> +        reg = <0x12661000 0x44c>;


Best regards,
Krzysztof