linux-kernel - Re: [PATCH V2 1/2] dt-bindings: i3c: Add AMD I3C master controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250901-sly-cicada-of-management-bf6d73@kuoka>
Date: Mon, 1 Sep 2025 07:22:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Manikanta Guntupalli <manikanta.guntupalli@....com>
Cc: git@....com, michal.simek@....com, alexandre.belloni@...tlin.com, 
	Frank.Li@....com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	kees@...nel.org, gustavoars@...nel.org, jarkko.nikula@...ux.intel.com, 
	linux-i3c@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org, radhey.shyam.pandey@....com, srinivas.goud@....com, 
	shubhrajyoti.datta@....com, manion05gk@...il.com
Subject: Re: [PATCH V2 1/2] dt-bindings: i3c: Add AMD I3C master controller
 support

On Fri, Aug 29, 2025 at 10:43:26PM +0530, Manikanta Guntupalli wrote:
> Add device tree binding documentation for the AMD I3C master controller.
> 
> The controller is represented by the compatible string "xlnx,axi-i3c-1.0".
> The binding specifies required properties including register space, clock,
> resets, interrupts, and provides an example usage.

These two are completely redundant and useless sentences. Binding cannot
specify anything else.

Instead describe the hardware.

Your previous patches for bindings also had completely redundant commit
msg. You need to write WHY you are doing changes or describe the
hardware. Repeating the code is pointless, we can read the code.

Best regards,
Krzysztof