lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c7182d12-4b57-4133-9412-7587a98b86bd@kernel.org>
Date: Mon, 1 Sep 2025 15:30:22 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>, hch@...radead.org, colyli@...nel.org,
 hare@...e.de, tieren@...as.com, axboe@...nel.dk, tj@...nel.org,
 josef@...icpanda.com, song@...nel.org, kmo@...erainc.com, satyat@...gle.com,
 ebiggers@...gle.com, neil@...wn.name, akpm@...ux-foundation.org
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, linux-raid@...r.kernel.org, yukuai3@...wei.com,
 yi.zhang@...wei.com, yangerkun@...wei.com, johnny.chenyi@...wei.com
Subject: Re: [PATCH RFC v3 03/15] md: fix mssing blktrace bio split events

On 9/1/25 12:32 PM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> If bio is split by internal chunksize of badblocks, the corresponding

badblocks ? Unclear.

> trace_block_split() is missing, causing blktrace can't catch the split
> events and make it hader to analyze IO behavior.

maybe:

trace_block_split() is missing, resulting in blktrace inability to catch BIO
split events and making it harder to analyze the BIO sequence.

would be better.

> 
> Fixes: 4b1faf931650 ("block: Kill bio_pair_split()")

Missing Cc: stable@...r.kernel.org

> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

With that,

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

(maybe drop the RFC on this patch series ? Sending a review tag for RFC patches
is odd...)

-- 
Damien Le Moal
Western Digital Research

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ