linux-kernel - Re: [PATCH RFC v3 01/15] block: cleanup bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fc7611b-ed38-7006-580d-f18b12c24ae7@huaweicloud.com>
Date: Mon, 1 Sep 2025 14:22:58 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Damien Le Moal <dlemoal@...nel.org>, Yu Kuai <yukuai1@...weicloud.com>,
 hch@...radead.org, colyli@...nel.org, hare@...e.de, tieren@...as.com,
 axboe@...nel.dk, tj@...nel.org, josef@...icpanda.com, song@...nel.org,
 kmo@...erainc.com, satyat@...gle.com, ebiggers@...gle.com, neil@...wn.name,
 akpm@...ux-foundation.org
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org, linux-raid@...r.kernel.org, yi.zhang@...wei.com,
 yangerkun@...wei.com, johnny.chenyi@...wei.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH RFC v3 01/15] block: cleanup bio_issue

Hi,

在 2025/09/01 11:43, Damien Le Moal 写道:
> On 9/1/25 12:32 PM, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@...wei.com>
>>
>> Now that bio->bi_issue is only used by io-latency to get bio issue time,
>> replace bio_issue with u64 time directly and remove bio_issue to make
>> code cleaner.
>>
>> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> 
> It seems that this patch is completely independent of the series.
> Maybe post it separately not as an RFC ?
> 

Actually, functionaly patch 1,2 must be applied before the following
cleanup, otherwise bio_submit_split_bioset() will add unnecessary
blk_time_get_ns() from blkcg_bio_issue_init() for mdraid, because
iolatency can never be initialized for mdraid, which is bio based.

Thanks,
Kuai