linux-kernel - Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLVhB4qQMurjS1Ap@kernel.org>
Date: Mon, 1 Sep 2025 12:01:59 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Max Kellermann <max.kellermann@...os.com>
Cc: Kiryl Shutsemau <kirill@...temov.name>, akpm@...ux-foundation.org,
	david@...hat.com, axelrasmussen@...gle.com, yuanchu@...gle.com,
	willy@...radead.org, hughd@...gle.com, mhocko@...e.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
	surenb@...gle.com, vishal.moola@...il.com
Subject: Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer
 parameters

On Mon, Sep 01, 2025 at 10:05:53AM +0200, Max Kellermann wrote:
> On Mon, Sep 1, 2025 at 9:33 AM Kiryl Shutsemau <kirill@...temov.name> wrote:
> >
> > On Sun, Aug 31, 2025 at 11:39:07AM +0200, Max Kellermann wrote:
> > > For improved const-correctness.
> >
> > It is not a proper commit message.
> 
> I believe it is proper for something as trivial as this. I think
> adding more text would just be noise, only wasting the time of people
> reading it. But that is a matter of perspective: I expect every
> competent C developer to know the concept of const-correctness.

True, but having a brief explanation why it's ok to constify these
parameters helps. Especially in longer patches.
 
> Do you believe the commit message of 29cfe7556bfd ("mm: constify more
> page/folio tests") is "proper"?

-- 
Sincerely yours,
Mike.