linux-kernel - Re: [PATCH v2] drm/sitronix/st7571-i2c: Make st7571_panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874itmv7uq.fsf@minerva.mail-host-address-is-not-set>
Date: Mon, 01 Sep 2025 11:29:33 +0200
From: Javier Martinez Canillas <javierm@...hat.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>, David
 Airlie <airlied@...il.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Marcus Folkesson
 <marcus.folkesson@...il.com>, Maxime Ripard <mripard@...nel.org>, Simona
 Vetter <simona@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2] drm/sitronix/st7571-i2c: Make st7571_panel_data
 variables static const

Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> writes:

> On Fri, Jul 18, 2025 at 05:25:25PM +0200, Javier Martinez Canillas wrote:
>> The kernel test robot reported that sparse gives the following warnings:
>> 
>> make C=2 M=drivers/gpu/drm/sitronix/
>>   CC [M]  st7571-i2c.o
>>   CHECK   st7571-i2c.c
>> st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static?
>> st7571-i2c.c:1039:26: warning: symbol 'st7571_config' was not declared. Should it be static?
>>   MODPOST Module.symvers
>>   LD [M]  st7571-i2c.ko
>> 
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202507180503.nfyD9uRv-lkp@intel.com
>> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
>> ---
>> 
>> Changes in v2:
>> - Also make the st7571_panel_data variables to be const (Thomas Zimmermann).
>> 
>>  drivers/gpu/drm/sitronix/st7571-i2c.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>

Pushed to drm-misc (drm-misc-next). Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat