linux-kernel - Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adb9e55e-0023-44b7-bc88-ed95be8dc71c@suse.cz>
Date: Mon, 1 Sep 2025 11:32:33 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Max Kellermann <max.kellermann@...os.com>,
 David Hildenbrand <david@...hat.com>
Cc: Kiryl Shutsemau <kirill@...temov.name>, akpm@...ux-foundation.org,
 axelrasmussen@...gle.com, yuanchu@...gle.com, willy@...radead.org,
 hughd@...gle.com, mhocko@...e.com, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
 rppt@...nel.org, surenb@...gle.com, vishal.moola@...il.com
Subject: Re: [PATCH v2 01/12] mm/shmem: add `const` to lots of pointer
 parameters

On 9/1/25 11:26, Max Kellermann wrote:
> On Mon, Sep 1, 2025 at 10:35 AM David Hildenbrand <david@...hat.com> wrote:
>> We usually write complete sentences, and there is nothing wrong with
>> repeating what the subject says.
>>
>> All the time it takes you to argue here would be better used improving
>> your patch descriptions.
> 
> Sure, but first I need to know what is really needed. Reviews on LKML
> are often contradictory, and it's easy to get pushed around from one
> corner to the next.
> 
> I just posted v4 with longer commit messages. I think that's a lot of
> unnecessary noise that takes a lot of time to read, but oh well, if
> that's what you guys really want...

No I don't think we want a passive-aggressive malicious compliance.
> (In the days of LLMs, writing is almost free, but reading all that
> redundant or generated garbage text becomes impossible. I think it is
> harmful to have so much redundant text because time spent reading it
> is time wasted. But that's just my opinion.)