linux-kernel - Re: [PATCH 3/3] pinctrl: renesas: Use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89294a30-47a7-45bf-80f7-04ffcad378a7@vivo.com>
Date: Mon, 1 Sep 2025 18:13:20 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
 "open list:PIN CONTROLLER - RENESAS" <linux-renesas-soc@...r.kernel.org>,
 "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] pinctrl: renesas: Use int type to store negative
 error codes


在 2025/9/1 17:07, Geert Uytterhoeven 写道:
> Hi Qianfeng,
>
> Thanks for your patch!
>
> On Sun, 31 Aug 2025 at 10:50, Qianfeng Rong <rongqianfeng@...o.com> wrote:
>> Change the 'ret' variable in ma35_pinctrl_parse_functions() from unsigned
> sh_pfc_pinconf_group_set


Thank you for pointing out my mistake.

>
>> int to int, as it needs to store either negative error codes or zero
>> returned by sh_pfc_pinconf_set().
>>
>> No effect on runtime.
> Fortunately the issue was indeed harmless.
>
>> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> Fixes: d0593c363f04ccc4 ("pinctrl: sh-pfc: Propagate errors on group config")
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> i.e. will queue in renesas-pinctrl for v6.18, with the above fixed.


Will do in the next version.

>
> Gr{oetje,eeting}s,
>
>                          Geert
Best regards,
Qianfeng