linux-kernel - Re: [PATCH 3/3] pinctrl: renesas: Use int type to store negative error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVDSmtpJ_4_Qj7RFukXqgFYo_9WUFKuKtc8DUQWGTNnew@mail.gmail.com>
Date: Mon, 1 Sep 2025 12:25:58 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	"open list:PIN CONTROLLER - RENESAS" <linux-renesas-soc@...r.kernel.org>, 
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] pinctrl: renesas: Use int type to store negative
 error codes

Hi Qianfeng,

On Mon, 1 Sept 2025 at 12:13, Qianfeng Rong <rongqianfeng@...o.com> wrote:
> 在 2025/9/1 17:07, Geert Uytterhoeven 写道:
> > On Sun, 31 Aug 2025 at 10:50, Qianfeng Rong <rongqianfeng@...o.com> wrote:
> >> Change the 'ret' variable in ma35_pinctrl_parse_functions() from unsigned
> > sh_pfc_pinconf_group_set
>
> Thank you for pointing out my mistake.
>
> >> int to int, as it needs to store either negative error codes or zero
> >> returned by sh_pfc_pinconf_set().
> >>
> >> No effect on runtime.
> > Fortunately the issue was indeed harmless.
> >
> >> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> > Fixes: d0593c363f04ccc4 ("pinctrl: sh-pfc: Propagate errors on group config")
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > i.e. will queue in renesas-pinctrl for v6.18, with the above fixed.
>
> Will do in the next version.

There is no need to resend; I will fix this up while applying.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds