linux-kernel - Re: [PATCH v4 00/12] mm: establish const-correctness for pointer parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <593bf6fc-bb12-42bb-b763-383ca16e3adb@lucifer.local>
Date: Mon, 1 Sep 2025 11:56:05 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: David Hildenbrand <david@...hat.com>
Cc: Max Kellermann <max.kellermann@...os.com>, akpm@...ux-foundation.org,
        axelrasmussen@...gle.com, yuanchu@...gle.com, willy@...radead.org,
        hughd@...gle.com, mhocko@...e.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Liam.Howlett@...cle.com, vbabka@...e.cz,
        rppt@...nel.org, surenb@...gle.com, vishal.moola@...il.com,
        linux@...linux.org.uk, James.Bottomley@...senpartnership.com,
        deller@....de, agordeev@...ux.ibm.com, gerald.schaefer@...ux.ibm.com,
        hca@...ux.ibm.com, gor@...ux.ibm.com, borntraeger@...ux.ibm.com,
        svens@...ux.ibm.com, davem@...emloft.net, andreas@...sler.com,
        dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
        hpa@...or.com, chris@...kel.net, jcmvbkbc@...il.com,
        viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz,
        weixugc@...gle.com, baolin.wang@...ux.alibaba.com, rientjes@...gle.com,
        shakeel.butt@...ux.dev, thuth@...hat.com, broonie@...nel.org,
        osalvador@...e.de, jfalempe@...hat.com, mpe@...erman.id.au,
        nysal@...ux.ibm.com, linux-arm-kernel@...ts.infradead.org,
        linux-parisc@...r.kernel.org, linux-s390@...r.kernel.org,
        sparclinux@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        conduct@...nel.org
Subject: Re: [PATCH v4 00/12] mm: establish const-correctness for pointer
 parameters

On Mon, Sep 01, 2025 at 12:43:42PM +0200, David Hildenbrand wrote:
> Let's all calm down a bit.

I am guessing you are not contradicting what I'm saying here but instead
trying to find a solution as to the _series_.

However, and I'm sure you agree - I want to underline my view that treating
people with disrespect should not be tolerated in the kernel.

I don't always feel we emphasise that enough.

>
> Max, I think this series here is valuable, and you can see that from the
> engagement from reviewers (this is a *good* thing, I sometimes wish I would
> get feedback that would help me improve my submissions).

Right - absolutely - the entire point of my review was to allow the series
to land so I agree there's something valuable here.

In some subsystems you might be waiting days/weeks for a response. It's
important (for Max) to realise how valuable this is.

I for one have given as much constructive criticism as I could with thhis
aim in mind, as have you and Vlastimil and Mike.

>
> So if you don't want to follow-up on this series to polish the patch
> descriptions etc,, let me now and I (or someone else around here) can drag
> it over the finishing line.

I guess if Max sends a respin that addresses review correctly and in good
faith I'll give it one more try, but Max - please try to have empathy and
respect in your responses.

This is literally all that I ask.

Otherwise am fine with this coming from somebody else.

>
> --
> Cheers
>
> David / dhildenb
>

Thanks, Lorenzo