lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d99496bf-6e67-4e64-97d5-6cfe563b8cbe@redhat.com>
Date: Mon, 1 Sep 2025 13:02:46 +0200
From: David Hildenbrand <david@...hat.com>
To: Max Kellermann <max.kellermann@...os.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, akpm@...ux-foundation.org,
 axelrasmussen@...gle.com, yuanchu@...gle.com, willy@...radead.org,
 hughd@...gle.com, mhocko@...e.com, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, Liam.Howlett@...cle.com, vbabka@...e.cz,
 rppt@...nel.org, surenb@...gle.com, vishal.moola@...il.com,
 linux@...linux.org.uk, James.Bottomley@...senpartnership.com, deller@....de,
 agordeev@...ux.ibm.com, gerald.schaefer@...ux.ibm.com, hca@...ux.ibm.com,
 gor@...ux.ibm.com, borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
 davem@...emloft.net, andreas@...sler.com, dave.hansen@...ux.intel.com,
 luto@...nel.org, peterz@...radead.org, tglx@...utronix.de, mingo@...hat.com,
 bp@...en8.de, x86@...nel.org, hpa@...or.com, chris@...kel.net,
 jcmvbkbc@...il.com, viro@...iv.linux.org.uk, brauner@...nel.org,
 jack@...e.cz, weixugc@...gle.com, baolin.wang@...ux.alibaba.com,
 rientjes@...gle.com, shakeel.butt@...ux.dev, thuth@...hat.com,
 broonie@...nel.org, osalvador@...e.de, jfalempe@...hat.com,
 mpe@...erman.id.au, nysal@...ux.ibm.com,
 linux-arm-kernel@...ts.infradead.org, linux-parisc@...r.kernel.org,
 linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, conduct@...nel.org
Subject: Re: [PATCH v4 00/12] mm: establish const-correctness for pointer
 parameters

On 01.09.25 12:54, Max Kellermann wrote:
> On Mon, Sep 1, 2025 at 12:43 PM David Hildenbrand <david@...hat.com> wrote:
>> Max, I think this series here is valuable, and you can see that from the
>> engagement from reviewers (this is a *good* thing, I sometimes wish I
>> would get feedback that would help me improve my submissions).
>>
>> So if you don't want to follow-up on this series to polish the patch
>> descriptions etc,, let me now and I (or someone else around here) can
>> drag it over the finishing line.
> 
> Thanks David - I do want to finish this, if there is a constructive
> path ahead. I know what you want, but I'm not so sure about the
> others.

I think we primarily want to briefly explain the what, the why, and why it is okay.

For getter/test functions the "why it is okay" it's trivial -- test function.
Personally, I would not spell out the individual functions in that case, as
long as they logically belong together (like "shmem test functions"
describe what you did in that patch).

For anything beyond that people likely expect a different reasoning.

For example the following change:

-static inline void folio_migrate_refs(struct folio *new, struct folio *old)
+static inline void folio_migrate_refs(struct folio *const new,
+				      const struct folio *const old)

Adds two "const" ways of doing things. As a reviewer, seeing something like that
buried in a patch raises questionmarks.

-- 
Cheers

David / dhildenb


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ