linux-kernel - Re: [PATCH 3/3] arm64: dts: ti: k3-pinctrl: Add the remaining macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3973566-0959-456d-bed7-c64bf3c34c44@ti.com>
Date: Mon, 1 Sep 2025 18:03:08 +0530
From: Akashdeep Kaur <a-kaur@...com>
To: Dhruva Gole <d-gole@...com>
CC: <vigneshr@...com>, <praneeth@...com>, <nm@...com>, <afd@...com>,
        <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <vishalm@...com>, <sebin.francis@...com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-pinctrl: Add the remaining macros

Hi Dhruva,

On 13/08/25 18:35, Dhruva Gole wrote:
> Akashdeep,
> 
...
>> Add the missing macros for deep sleep configuration control.
> 
> Please can you add sources/ links to the TRM/collateral and sections where you get
> all this information from?

Added TRM reference links
> 
>> Reword the existing deep sleep macros to provide combinations that can
>> directly be used in device tree files.
> 
> I am not very clear on what this line is trying to say. Can you explain
> a bit more with an example of a reword and how it is helping?
Added example
> 
>>
>> Signed-off-by: Akashdeep Kaur <a-kaur@...com>
...
>> +#define WKUP_LVL_EN_SHIFT	    (7)
>> +#define WKUP_LVL_POL_SHIFT	    (8)
>> +#define ST_EN_SHIFT		        (14)
>> +#define DRV_STR_SHIFT		    (19)
>> +#define DS_ISO_OVERRIDE_EN_SHIFT (22)
>> +#define DS_ISO_BYPASS_EN_SHIFT  (23)
> 
> Seeing it on lore and in my git log -p as well, the alignment looks off.
> Please fix it.
> 
Fixed
>>   
>>   /* Schmitt trigger configuration */
>>   #define ST_DISABLE		(0 << ST_EN_SHIFT)
...
>> +
>> +#define WKUP_DISABLE        (0 << WKUP_EN_SHIFT)
>> +
> 
> These too, fix all alignment issues please.
Fixed
> 
>>   /* Only these macros are expected be used directly in device tree files */
>>   #define PIN_OUTPUT		(INPUT_DISABLE | PULL_DISABLE)
...

Regards,
Akashdeep Kaur