[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d6ab538c-f3b1-4513-8226-773a13510f86@ti.com>
Date: Mon, 1 Sep 2025 18:06:10 +0530
From: Akashdeep Kaur <a-kaur@...com>
To: Vignesh Raghavendra <vigneshr@...com>, <praneeth@...com>, <nm@...com>,
<afd@...com>, <kristo@...nel.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
CC: <vishalm@...com>, <sebin.francis@...com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-pinctrl: Add the remaining macros
Hi Vignesh,
On 13/08/25 20:08, Vignesh Raghavendra wrote:
>
>
> On 31/07/25 17:26, Akashdeep Kaur wrote:
>> Add the drive strength, schmitt trigger enable macros to pinctrl file.
...
>> +#define DS_ISO_OVERRIDE_EN_SHIFT (22)
>> +#define DS_ISO_BYPASS_EN_SHIFT (23)
>
> These *_SHIFT macros are mostly arranged in ascending order of bit
> position, please follow the same.
Rearranged the newly added macros to mostly fit in ascending order.
>
> Also, ST_EN_SHIFT is already defined ?
Removed
>
>>
>> /* Schmitt trigger configuration */
>> #define ST_DISABLE (0 << ST_EN_SHIFT)
...
>> -#define PIN_DS_PULL_DOWN (0 << DS_PULLTYPE_SEL_SHIFT)
>> -#define PIN_DS_PULL_UP (1 << DS_PULLTYPE_SEL_SHIFT)
>
> No we cannot delete these. There maybe downstream dts files already
> using these macros and thus can cause incompatibilities.
Added these back for backward compatibility
>
>> +#define PIN_DS_FORCE_ENABLE (1 << FORCE_DS_EN_SHIFT)
...
>> +#define WKUP_EN_LEVEL_HIGH (WKUP_ENABLE | WKUP_ON_LEVEL | WKUP_LEVEL_HIGH)
>> +#define WKUP_EN WKUP_EN_EDGE
>
> All existing macros in this block have PIN_* suffix. Please align with
> the same.
Added
>
>>
>> /* Default mux configuration for gpio-ranges to use with pinctrl */
>> #define PIN_GPIO_RANGE_IOPAD (PIN_INPUT | 7)
>
>
> For future versions, please split the changes to 2 patches: one for
> white-space changes only and one for addition of new macros.
Point Noted
Regards,
Akashdeep Kaur
Powered by blists - more mailing lists