linux-kernel - Re: [PATCH 20/29] drm/tidss: crtc: Change variable name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00db28be-aa7d-4e51-a0b0-090d508b45be@suse.de>
Date: Tue, 2 Sep 2025 15:51:06 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Maxime Ripard <mripard@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Jyri Sarha <jyri.sarha@....fi>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Devarsh Thakkar <devarsht@...com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/29] drm/tidss: crtc: Change variable name



Am 02.09.25 um 10:32 schrieb Maxime Ripard:
> The tidss_crtc_reset() function stores a pointer to struct
> tidss_crtc_state in a variable called tcrtc, while it uses tcrtc as a
> pointer to struct tidss_crtc in the rest of the driver.
>
> This is confusing, so let's change the variable name.
>
> Signed-off-by: Maxime Ripard <mripard@...nel.org>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/gpu/drm/tidss/tidss_crtc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_crtc.c b/drivers/gpu/drm/tidss/tidss_crtc.c
> index 091f82c86f53bc76c572de4723746af2e35ce1c1..db7c5e4225e6247047087a35a2e6422950fc0111 100644
> --- a/drivers/gpu/drm/tidss/tidss_crtc.c
> +++ b/drivers/gpu/drm/tidss/tidss_crtc.c
> @@ -343,24 +343,24 @@ static void tidss_crtc_disable_vblank(struct drm_crtc *crtc)
>   	tidss_runtime_put(tidss);
>   }
>   
>   static void tidss_crtc_reset(struct drm_crtc *crtc)
>   {
> -	struct tidss_crtc_state *tcrtc;
> +	struct tidss_crtc_state *tstate;
>   
>   	if (crtc->state)
>   		__drm_atomic_helper_crtc_destroy_state(crtc->state);
>   
>   	kfree(crtc->state);
>   
> -	tcrtc = kzalloc(sizeof(*tcrtc), GFP_KERNEL);
> -	if (!tcrtc) {
> +	tstate = kzalloc(sizeof(*tstate), GFP_KERNEL);
> +	if (!tstate) {
>   		crtc->state = NULL;
>   		return;
>   	}
>   
> -	__drm_atomic_helper_crtc_reset(crtc, &tcrtc->base);
> +	__drm_atomic_helper_crtc_reset(crtc, &tstate->base);
>   }
>   
>   static struct drm_crtc_state *tidss_crtc_duplicate_state(struct drm_crtc *crtc)
>   {
>   	struct tidss_crtc_state *state, *current_state;
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)