linux-kernel - Re: [PATCH 18/29] drm/tidss: Convert to drm logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c24cd299-388a-4223-9409-5a882b25c2f6@suse.de>
Date: Tue, 2 Sep 2025 15:49:08 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Maxime Ripard <mripard@...nel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Jyri Sarha <jyri.sarha@....fi>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Devarsh Thakkar <devarsht@...com>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 18/29] drm/tidss: Convert to drm logging

Hi

Am 02.09.25 um 10:32 schrieb Maxime Ripard:
> DRM drivers should prefer the drm logging functions to the dev logging
> ones when possible. Let's convert the existing dev_* logs to their drm
> counterparts.
>
> Signed-off-by: Maxime Ripard <mripard@...nel.org>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

> ---
>   drivers/gpu/drm/tidss/tidss_crtc.c  | 4 ++--
>   drivers/gpu/drm/tidss/tidss_dispc.c | 6 ++++--
>   2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_crtc.c b/drivers/gpu/drm/tidss/tidss_crtc.c
> index da89fd01c3376352840185cd4ac355dd41fd5bb1..f497138ad053ed4be207e12eeee6c304e1c949bd 100644
> --- a/drivers/gpu/drm/tidss/tidss_crtc.c
> +++ b/drivers/gpu/drm/tidss/tidss_crtc.c
> @@ -101,11 +101,11 @@ static int tidss_crtc_atomic_check(struct drm_crtc *crtc,
>   
>   	mode = &crtc_state->adjusted_mode;
>   
>   	ok = dispc_vp_mode_valid(dispc, hw_videoport, mode);
>   	if (ok != MODE_OK) {
> -		dev_dbg(ddev->dev, "%s: bad mode: %ux%u pclk %u kHz\n",
> +		drm_dbg(ddev, "%s: bad mode: %ux%u pclk %u kHz\n",
>   			__func__, mode->hdisplay, mode->vdisplay, mode->clock);
>   		return -EINVAL;
>   	}
>   
>   	if (drm_atomic_crtc_needs_modeset(crtc_state))
> @@ -170,11 +170,11 @@ static void tidss_crtc_atomic_flush(struct drm_crtc *crtc,
>   	struct tidss_crtc *tcrtc = to_tidss_crtc(crtc);
>   	struct drm_device *ddev = crtc->dev;
>   	struct tidss_device *tidss = to_tidss(ddev);
>   	unsigned long flags;
>   
> -	dev_dbg(ddev->dev, "%s: %s is %sactive, %s modeset, event %p\n",
> +	drm_dbg(ddev, "%s: %s is %sactive, %s modeset, event %p\n",
>   		__func__, crtc->name, crtc->state->active ? "" : "not ",
>   		drm_atomic_crtc_needs_modeset(crtc->state) ? "needs" : "doesn't need",
>   		crtc->state->event);
>   
>   	/*
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index 190d32ed53f84371456ccb997d1898ed5cef9db1..8b1d6b72f303b91fbf86f7d0e351800804757126 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -1063,24 +1063,26 @@ struct dispc_bus_format *dispc_vp_find_bus_fmt(struct dispc_device *dispc,
>   }
>   
>   int dispc_vp_bus_check(struct dispc_device *dispc, u32 hw_videoport,
>   		       const struct drm_crtc_state *state)
>   {
> +	struct tidss_device *tidss = dispc->tidss;
> +	struct drm_device *dev = &tidss->ddev;
>   	const struct tidss_crtc_state *tstate = to_tidss_crtc_state(state);
>   	const struct dispc_bus_format *fmt;
>   
>   	fmt = dispc_vp_find_bus_fmt(dispc, hw_videoport, tstate->bus_format,
>   				    tstate->bus_flags);
>   	if (!fmt) {
> -		dev_dbg(dispc->dev, "%s: Unsupported bus format: %u\n",
> +		drm_dbg(dev, "%s: Unsupported bus format: %u\n",
>   			__func__, tstate->bus_format);
>   		return -EINVAL;
>   	}
>   
>   	if (dispc->feat->vp_bus_type[hw_videoport] != DISPC_VP_OLDI_AM65X &&
>   	    fmt->is_oldi_fmt) {
> -		dev_dbg(dispc->dev, "%s: %s is not OLDI-port\n",
> +		drm_dbg(dev, "%s: %s is not OLDI-port\n",
>   			__func__, dispc->feat->vp_name[hw_videoport]);
>   		return -EINVAL;
>   	}
>   
>   	return 0;
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)