linux-kernel - Re: [PATCH v2 1/2] dt-bindings: clock: renesas,r9a09g077/87: Add Ethernet and GMAC clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8v9SBF7zkCq4zgZJV=B-=t6Dea7dG=whA0YjwOrPrO5Hg@mail.gmail.com>
Date: Tue, 2 Sep 2025 16:37:26 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Magnus Damm <magnus.damm@...il.com>, linux-renesas-soc@...r.kernel.org, 
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
	Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: renesas,r9a09g077/87: Add
 Ethernet and GMAC clocks

Hi Geert,

Thank you for the review.

On Tue, Sep 2, 2025 at 2:02 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, 1 Sept 2025 at 20:30, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Add clock definitions for Ethernet (ETCLK A-E) and GMAC (GMAC0-2)
> > peripherals to both R9A09G077 and R9A09G087 SoCs. These definitions
> > are required for describing Ethernet and GMAC devices in device trees.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
>
> Thanks for your patch!
>
> > --- a/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
> > +++ b/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h
> > @@ -26,5 +26,14 @@
> >  #define R9A09G077_CLK_PCLKL            14
> >  #define R9A09G077_SDHI_CLKHS           15
> >  #define R9A09G077_USB_CLK              16
> > +#define R9A09G077_ETCLKA               17
> > +#define R9A09G077_ETCLKB               18
> > +#define R9A09G077_ETCLKC               19
> > +#define R9A09G077_ETCLKD               20
> > +#define R9A09G077_ETCLKE               21
>
> These five LGTM.
>
> > +#define R9A09G077_GMAC0_PCLKH          22
> > +#define R9A09G077_GMAC1_PCLKAH         23
> > +#define R9A09G077_GMAC2_PCLKAH         24
>
> I doubt you really need these, cfr. my comments on [PATCH v2 2/2].
>
As agreed on patch 2/2, I will drop these macros in v3.

Cheers,
Prabhakar