linux-kernel - Re: [PATCH 08/10] gpu: nova-core: falcon: Add support to check if RISC-V is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <efob3ohi7d4em2sjvxm7bfusqvalrbhu2xi4c2gwpwhpuvrrah@n2x654p4ydzw>
Date: Tue, 2 Sep 2025 10:08:57 +1000
From: Alistair Popple <apopple@...dia.com>
To: Timur Tabi <ttabi@...dia.com>
Cc: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, 
	Alexandre Courbot <acourbot@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>, 
	"lossin@...nel.org" <lossin@...nel.org>, "ojeda@...nel.org" <ojeda@...nel.org>, 
	"boqun.feng@...il.com" <boqun.feng@...il.com>, "a.hindborg@...nel.org" <a.hindborg@...nel.org>, 
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "tmgross@...ch.edu" <tmgross@...ch.edu>, 
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "simona@...ll.ch" <simona@...ll.ch>, 
	"mripard@...nel.org" <mripard@...nel.org>, 
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	John Hubbard <jhubbard@...dia.com>, "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>, 
	"bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>, 
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Joel Fernandes <joelagnelf@...dia.com>, 
	"gary@...yguo.net" <gary@...yguo.net>
Subject: Re: [PATCH 08/10] gpu: nova-core: falcon: Add support to check if
 RISC-V is active

On 2025-08-30 at 04:48 +1000, Timur Tabi <ttabi@...dia.com> wrote...
> On Wed, 2025-08-27 at 18:20 +1000, Alistair Popple wrote:
> > +    pub(crate) fn is_riscv_active(&self, bar: &Bar0) -> Result<bool> {
> > +        let cpuctl = regs::NV_PRISCV_RISCV_CPUCTL::read(bar, &E::ID);
> > +        Ok(cpuctl.active_stat())
> > +    }
> 
> I think this should return just bool instead of Result<bool>

Agreed. And looking at some of the other sequencer/falcon code in Joel's series
I believe similar comments apply there. I assume something changed with the
register reading code to make this possible.