linux-kernel - Re: [PATCH 1/3] crypto: sha1 - Implement export_core() and import

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62ea21e5-d1b4-4c86-b836-219a966f9f81@gmail.com>
Date: Tue, 2 Sep 2025 11:23:13 +0300
From: Ovidiu Panait <ovidiu.panait.oss@...il.com>
To: Eric Biggers <ebiggers@...nel.org>, linux-crypto@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
 "Jason A . Donenfeld" <Jason@...c4.com>, qat-linux@...el.com,
 Giovanni Cabiddu <giovanni.cabiddu@...el.com>
Subject: Re: [PATCH 1/3] crypto: sha1 - Implement export_core() and
 import_core()

On 9/1/25 7:50 PM, Eric Biggers wrote:
> Since commit 9d7a0ab1c753 ("crypto: ahash - Handle partial blocks in
> API"), the recently-added export_core() and import_core() methods in
> struct shash_alg have effectively become mandatory (even though it is
> not tested or enforced), since legacy drivers that need a fallback
> depend on them.  Make crypto/sha1.c compatible with these legacy drivers
> by adding export_core() and import_core() methods to it.
> 
> Reported-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
> Reported-by: Ovidiu Panait <ovidiu.panait.oss@...il.com>
> Closes: https://lore.kernel.org/r/aLSnCc9Ws5L9y+8X@gcabiddu-mobl.ger.corp.intel.com
> Fixes: b10a74abcfc5 ("crypto: sha1 - Use same state format as legacy drivers")
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---

Tested-by: Ovidiu Panait <ovidiu.panait.oss@...il.com>

Thanks,
Ovidiu